search

TuringLang / Bijectors.jl

Implementation of normalising flows and constrained random variable transformations
https://turinglang.org/Bijectors.jl/
MIT License
196 stars 32 forks source link

Remove unnecessary (and incorrect) Zygote rule for PDBijector #286

Closed yebai closed 10 months ago

yebai commented 10 months ago

Addresses https://github.com/TuringLang/Turing.jl/pull/2018#issuecomment-1680944327

devmotion commented 10 months ago

Long-term ideally we would not define Zygote-specific rules anymore but mainly/only ChainRules definitions.

To this PR: Doesn't this require https://github.com/FluxML/Zygote.jl/pull/1444? If so, I guess we should add/update the lower bound for Zygote.

yebai commented 10 months ago

To this PR: Doesn't this require https://github.com/FluxML/Zygote.jl/pull/1444? If so, I guess we should add/update the lower bound for Zygote.

Fixed.