search

TuringLang / Bijectors.jl

Implementation of normalising flows and constrained random variable transformations
https://turinglang.org/Bijectors.jl/
MIT License
196 stars 32 forks source link

Bugfix for `SimplexBijector` on `Matrix` #302

Closed torfjelde closed 2 months ago

torfjelde commented 2 months ago

Related: https://github.com/TuringLang/Turing.jl/issues/2190

torfjelde commented 2 months ago

@yebai @devmotion should be a quick merge

torfjelde commented 2 months ago

The PR made me wonder whether it would be possible to improve performance of with_logabsdet_jacobian for SimplexBijector by not performing transform and logabsdetjac separately when both are requested. Doesn't block this PR and maybe would lead to more code duplications though.

Definitively! But yeah, probs for another PR (I'll make issue) :+1: