Skellam (special case) is broken with Zygote

TuringLang / DistributionsAD.jl

Automatic differentiation of Distributions using Tracker, Zygote, ForwardDiff and ReverseDiff

MIT License

151 stars 30 forks source link

Open devmotion opened 3 years ago

devmotion commented 3 years ago

Currently, these distributions are broken due to https://github.com/FluxML/Zygote.jl/issues/873. As discussed in https://github.com/TuringLang/Bijectors.jl/pull/155, the corresponding tests are marked as broken. The issue will be fixed upstream.

devmotion commented 3 years ago

The main issue was fixed upstream, only some interesting issue due to Zygote._zero with ChainRulesCore.NotImplemented for matrices of Skellam variates is left: https://github.com/TuringLang/DistributionsAD.jl/pull/172