github-actions[bot]
commented
10 months ago Pull Request Test Coverage Report for Build 6977964954
- 8 of 9 (88.89%) changed or added relevant lines in 1 file are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage increased (+0.02%) to 81.573%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| src/context_implementations.jl | 8 | 9 | 88.89% | ||
| <!-- | Total: | 8 | 9 | 88.89% | --> |
| Totals | |
|---|---|
| Change from base Build 6952497716: | 0.02% |
| Covered Lines: | 2572 |
| Relevant Lines: | 3153 |
codecov[bot]
devmotion
This PR adds two new methods:
acclogp_assume!!acclogp_observe!!The idea is to provide slightly more control over the
acclogp!!process, beyond (#563).The main motivation for this, is to fix the bug where particle samplers in Turing.jl currently do not respect the contextual tilde-pipeline since we accumulate the
logpin the "leaf" of the tilde-pipeline, e.g.observeandassume:This means that any context which alters the value of
logp, e.g.MiniBatchContext, will have no effect.After this PR, particle samplers can overload
acclogp_observe!!to runLibtask.produce(logpdf(dist, value)), which occurs at the very end of the tilde-pipeline, hence allowing these samplers to also respect the context behaviors.