Closed devmotion closed 9 months ago
This looks good to me, but there's something weird happening with the tests; looking into this.
@devmotion Could you bump patch version?
Totals | |
---|---|
Change from base Build 7506113239: | -0.5% |
Covered Lines: | 2329 |
Relevant Lines: | 2936 |
Attention: 1 lines
in your changes are missing coverage. Please review.
Comparison is base (
c6e3b6b
) 79.64% compared to head (4ff8324
) 84.28%. Report is 1 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
src/abstract_varinfo.jl | 75.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
src/abstract_varinfo.jl | 3 | 4 | 75.0% | ||
<!-- | Total: | 4 | 5 | 80.0% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
src/model.jl | 1 | 87.88% | ||
src/simple_varinfo.jl | 5 | 79.64% | ||
src/varinfo.jl | 6 | 85.6% | ||
src/threadsafe.jl | 13 | 44.23% | ||
<!-- | Total: | 25 | --> |
Totals | |
---|---|
Change from base Build 7615074409: | 0.02% |
Covered Lines: | 2677 |
Relevant Lines: | 3163 |
I think TuringLang/Turing.jl/pull/2156 will fix the test issues.
@torfjelde The PR is ready for another round of review 🙂
Fixes the error in https://github.com/TuringLang/Turing.jl/issues/2151 on Julia 1.10 for me:
cc @sjwild