TuringLang / DynamicPPL.jl

Implementation of domain-specific language (DSL) for dynamic probabilistic programming
https://turinglang.org/DynamicPPL.jl/
MIT License
157 stars 26 forks source link

Added back `prob` and `logprob` macros #609

Closed torfjelde closed 3 months ago

torfjelde commented 3 months ago

604 removed these two macros, but this will just result in ambiguous errors for lots of users (this feature has been displayed in the Turing.jl docs and we know there are people using it) without telling them anything about why the changes was made.

This PR makes them instead error, providing some information on where to find discussion + how to "replace" some of its functionality.

coveralls commented 3 months ago

Pull Request Test Coverage Report for Build 9126744062

Details


Totals Coverage Status
Change from base Build 9126213178: 0.03%
Covered Lines: 2653
Relevant Lines: 3419

💛 - Coveralls
codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 76.27%. Comparing base (5b53be7) to head (6f15c32). Report is 3 commits behind head on master.

:exclamation: Current head 6f15c32 differs from pull request most recent head bedb345

Please upload reports for the commit bedb345 to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #609 +/- ## ========================================== - Coverage 76.93% 76.27% -0.66% ========================================== Files 30 29 -1 Lines 3572 3439 -133 ========================================== - Hits 2748 2623 -125 + Misses 824 816 -8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.