TuringLang / DynamicPPL.jl

Implementation of domain-specific language (DSL) for dynamic probabilistic programming
https://turinglang.org/DynamicPPL.jl/
MIT License
157 stars 26 forks source link

`missing` kwarg not handled correctly #617

Closed torfjelde closed 3 months ago

torfjelde commented 3 months ago

https://github.com/TuringLang/Turing.jl/issues/2259

We perform the inargnames check for both args and kwargs, and so then we should also perform the ismissing check for both args and kwargs (only do it for args atm).

torfjelde commented 3 months ago

@yebai might want to have a look

github-actions[bot] commented 3 months ago

Pull Request Test Coverage Report for Build 9481723129

Details


Files with Coverage Reduction New Missed Lines %
src/model.jl 1 88.35%
src/varinfo.jl 6 92.13%
src/simple_varinfo.jl 6 82.61%
src/threadsafe.jl 12 53.51%
<!-- Total: 25 -->
Totals Coverage Status
Change from base Build 9387717755: -1.5%
Covered Lines: 2718
Relevant Lines: 3445

💛 - Coveralls
github-actions[bot] commented 3 months ago

Pull Request Test Coverage Report for Build 9481726759

Details


Totals Coverage Status
Change from base Build 9387717755: -1.3%
Covered Lines: 2724
Relevant Lines: 3445

💛 - Coveralls
github-actions[bot] commented 3 months ago

Pull Request Test Coverage Report for Build 9481723129

Details


Files with Coverage Reduction New Missed Lines %
src/model.jl 1 88.35%
src/varinfo.jl 6 92.13%
src/simple_varinfo.jl 6 82.61%
src/threadsafe.jl 12 53.51%
<!-- Total: 25 -->
Totals Coverage Status
Change from base Build 9387717755: -1.5%
Covered Lines: 2718
Relevant Lines: 3445

💛 - Coveralls
coveralls commented 3 months ago

Pull Request Test Coverage Report for Build 9481726759

Details


Totals Coverage Status
Change from base Build 9387717755: -1.3%
Covered Lines: 2724
Relevant Lines: 3445

💛 - Coveralls
coveralls commented 3 months ago

Pull Request Test Coverage Report for Build 9481723129

Details


Files with Coverage Reduction New Missed Lines %
src/model.jl 1 88.35%
src/varinfo.jl 6 92.13%
src/simple_varinfo.jl 6 82.61%
src/threadsafe.jl 12 53.51%
<!-- Total: 25 -->
Totals Coverage Status
Change from base Build 9387717755: -1.5%
Covered Lines: 2718
Relevant Lines: 3445

💛 - Coveralls
github-actions[bot] commented 3 months ago

Pull Request Test Coverage Report for Build 9481723129

Details


Files with Coverage Reduction New Missed Lines %
src/model.jl 1 88.35%
src/varinfo.jl 6 92.13%
src/simple_varinfo.jl 6 82.61%
src/threadsafe.jl 12 53.51%
<!-- Total: 25 -->
Totals Coverage Status
Change from base Build 9387717755: -0.02%
Covered Lines: 2756
Relevant Lines: 3431

💛 - Coveralls
coveralls commented 3 months ago

Pull Request Test Coverage Report for Build 9481723129

Details


Files with Coverage Reduction New Missed Lines %
src/model.jl 1 88.35%
src/varinfo.jl 6 92.13%
src/simple_varinfo.jl 6 82.61%
src/threadsafe.jl 12 53.51%
<!-- Total: 25 -->
Totals Coverage Status
Change from base Build 9387717755: -0.02%
Covered Lines: 2756
Relevant Lines: 3431

💛 - Coveralls
coveralls commented 3 months ago

Pull Request Test Coverage Report for Build 9481726759

Details


Totals Coverage Status
Change from base Build 9387717755: -0.02%
Covered Lines: 2756
Relevant Lines: 3431

💛 - Coveralls
coveralls commented 3 months ago

Pull Request Test Coverage Report for Build 9481726759

Details


Totals Coverage Status
Change from base Build 9387717755: -0.02%
Covered Lines: 2756
Relevant Lines: 3431

💛 - Coveralls
yebai commented 3 months ago

Auto-merging is failing again -- I am merging manually since all tests passed.