Closed sunxd3 closed 1 month ago
@yebai @torfjelde I don't think we need this PR now. The motivation of this PR was that we want customized setmodel
for different AD backend. We more or less established at https://github.com/TuringLang/Turing.jl/pull/2231#issuecomment-2192601314 that we will postpone this until we need it.
@sunxd3 let's still transfer these methods from Turing
into DynamicPPL
so we can maintain them from DynamicPPL
.
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
src/model.jl | 1 | 87.0% | ||
src/simple_varinfo.jl | 5 | 82.18% | ||
src/varinfo.jl | 6 | 84.85% | ||
src/threadsafe.jl | 12 | 46.73% | ||
<!-- | Total: | 24 | --> |
Totals | |
---|---|
Change from base Build 9945722994: | 0.03% |
Covered Lines: | 2807 |
Relevant Lines: | 3448 |
@torfjelde another look? 🙏
LGTM:)
ref: https://github.com/TuringLang/Turing.jl/pull/2231#issuecomment-2192601314