search

TuringLang / DynamicPPL.jl

Implementation of domain-specific language (DSL) for dynamic probabilistic programming
https://turinglang.org/DynamicPPL.jl/
MIT License
157 stars 26 forks source link

Fix for `check_model` on Julia <1.9 #631

Closed torfjelde closed 1 month ago

torfjelde commented 2 months ago

isassigned(::AbstractArray, ::CartesianIndex) is not supported on Julia <1.9, even though it can be returned by eachindex.

Ref: https://github.com/TuringLang/Turing.jl/pull/2231 whose CI is currently failiing because of this (https://github.com/TuringLang/Turing.jl/actions/runs/9879092184/job/27284539618?pr=2231)

torfjelde commented 2 months ago

A bit confused as to why this isn't also failiing on Julia 1.6 though 😕

coveralls commented 2 months ago

Pull Request Test Coverage Report for Build 9943962149

Details

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/debug_utils.jl 0 4 0.0%
<!-- Total: 0 4 0.0% -->
Totals Coverage Status
Change from base Build 9928537337: -0.04%
Covered Lines: 2801
Relevant Lines: 3442
💛 - Coveralls