Closed torfjelde closed 1 month ago
Looks reasonable, maybe we can just move update_values!!
to out into utils.jl
.
Regardless, I can write some tests for this.
Can I get your permission to just commit to this PR? @torfjelde
Looks reasonable, maybe we can just move update_values!! to out into utils.jl.
Indeed:)
Can I get your permission to just commit to this PR? @torfjelde
Yep, go for it!
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
src/sampler.jl | 16 | 17 | 94.12% | ||
src/varinfo.jl | 0 | 3 | 0.0% | ||
<!-- | Total: | 20 | 24 | 83.33% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
src/model.jl | 1 | 87.0% | ||
src/threadsafe.jl | 12 | 45.19% | ||
<!-- | Total: | 13 | --> |
Totals | |
---|---|
Change from base Build 10038508405: | -0.05% |
Covered Lines: | 2811 |
Relevant Lines: | 3455 |
LGTM:) Unfortunately I seems I can't approve because I'm the creator of the PR 🙃
wait till https://github.com/TuringLang/DynamicPPL.jl/pull/626 to merge, then I'll fix the versioning and potential errors
Do we need to make this breaking? If not, we can combine the release with https://github.com/TuringLang/DynamicPPL.jl/pull/626
Ref: https://github.com/TuringLang/Turing.jl/issues/2286
Quick and dirty implementation, but does the trick.
I probably shouldn't spend much time on this (have other PRs that I need to complete), but figured I'd just add this here in case someone else wants to complete it (maybe @sunxd3 or @mhauru has time) :)
Basically, it's just missing: