Remove `base_model` field from `BUGSModel`

TuringLang / JuliaBUGS.jl

A domain specific language (DSL) for probabilistic graphical models

https://turinglang.org/JuliaBUGS.jl/

MIT License

21 stars 3 forks source link

Remove `base_model` field from `BUGSModel` #204

Closed sunxd3 closed 3 months ago

sunxd3 commented 3 months ago

ref: https://github.com/compintell/Tapir.jl/issues/195. Recursive definition is problematic. The field is not actively used, so delete for simplicity.

A side effect is that decondition is also removed. decondition is not necessary in the sense that its functionality can be achieved by explicitly keeping the original model around. The function is not currently used by Gibbs.

coveralls commented 3 months ago

Pull Request Test Coverage Report for Build 10043718992

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.09%) to 82.211%

Totals
Change from base Build 9928535952:	-0.09%
Covered Lines:	1428
Relevant Lines:	1737

💛 - Coveralls

sunxd3 commented 3 months ago

closed, as #205 is a better fix