TuringLang / JuliaBUGS.jl

A domain specific language (DSL) for probabilistic graphical models
https://turinglang.org/JuliaBUGS.jl/
MIT License
22 stars 4 forks source link

Make `BUGSModel` parametric so Tapir works with JuliaBUGS models #205

Closed sunxd3 closed 3 months ago

sunxd3 commented 3 months ago

Fix https://github.com/TuringLang/JuliaBUGS.jl/issues/202

sunxd3 commented 3 months ago
Screenshot 2024-07-29 at 10 16 15 AM

compat errors on 1.9. @willtebbutt how should I resolve this?

willtebbutt commented 3 months ago

Ugh. Sadly you'll have to do something like this, and only run the Tapir.jl tests if you happen to be testing on version 1.10 or greater.

Sorting this out is on my todo list.

coveralls commented 3 months ago

Pull Request Test Coverage Report for Build 10146783820

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details


Totals Coverage Status
Change from base Build 9928535952: 0.0%
Covered Lines: 1437
Relevant Lines: 1746

💛 - Coveralls
sunxd3 commented 3 months ago

I don't think I can do that without causing an error: I can't have Tapir in the dep/extras field, and Julia complains when I try to restrict the pkg version when it's not in dep/extras

willtebbutt commented 3 months ago

Ohhhh ofc, you're completely right 👍