Open alecloudenback opened 7 months ago
Attention: Patch coverage is 5.12821%
with 37 lines
in your changes missing coverage. Please review.
Project coverage is 81.90%. Comparing base (
5f8e591
) to head (20e76a4
).:exclamation: Current head 20e76a4 differs from pull request most recent head 1144212
Please upload reports for the commit 1144212 to get more accurate results.
Files | Patch % | Lines |
---|---|---|
ext/MCMCChainsMakieExt.jl | 0.00% | 37 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
After talking with the Makie devs on Discord:
convert_arguments
isn't really a path because all it will do is be able to plot the data into a single plot (no faceting by parameter or chain) or convey metadata (e.g. parameter name or chain number)trace(chains)
). Adding a new method to plot
isn't well defined or supported by Makie.The latest commit is the recommended approach, including registering an error hint if a Makie-related package isn't yet loaded and trace
is called.
@devmotion / @theogf pinging since you had some initial feedback requesting a recipes-based approach, but I don't think that works when wanted to plot multiple chains/parameters (see my last post). If good with the overall approach here, I can knock out the remaining To-Dos.
Current Status:
A color-blind-friendly color scheme (
:tol_vibrant
) is used to plot the trance and parameter densities for each parameter in each chain.Sample plots:
Basic Layout
Large number of parameters
Large number of chains
To-do
Extend(not good idea)Makie.plot
instead of a newmyplot
functionSample Script