Open sethaxen opened 2 years ago
Note that the test suite doesn't currently pass because due to some bugs on main. I fixed one in this PR, but not the other.
(I merged my own PR that lets users skip ESS computations since I wanted to merge a handful of related changes in that PR, but I'm still open to switching to this implementation if we find a way to avoid duplicate computations.)
This PR makes
ess
andsup_ess
properties ofPsis
instead of fields, so that they are lazily computed only if necessary instead of in eachpsis
call. It also fixes some potential issues where variables of one type are then aliased to have a different type, which may cause issues with type inference (it did in older Julia versions at least) and also makes the code more complicated.