TuringLang / ParetoSmooth.jl

An implementation of PSIS algorithms in Julia.
http://turinglang.org/ParetoSmooth.jl/
MIT License
19 stars 12 forks source link

fix show() methods #68

Closed svilupp closed 1 year ago

svilupp commented 1 year ago

pass .data accessor to pretty_table so it sees the right Matrix

Fixes https://github.com/TuringLang/ParetoSmooth.jl/issues/69

svilupp commented 1 year ago

Opened only as a Draft to show the solution. I'd need to take out the formatting change (annoying default, sorry)

Tests for relevant bits pass but I do not pass all tests. I get a lot of errors outside of tests because of my arm platform (eg, cannot install libtask etc)

codecov[bot] commented 1 year ago

Codecov Report

Base: 82.73% // Head: 82.59% // Decreases project coverage by -0.14% :warning:

Coverage data is based on head (92a92b6) compared to base (4608eef). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #68 +/- ## ========================================== - Coverage 82.73% 82.59% -0.15% ========================================== Files 11 11 Lines 336 339 +3 ========================================== + Hits 278 280 +2 - Misses 58 59 +1 ``` | [Impacted Files](https://codecov.io/gh/TuringLang/ParetoSmooth.jl/pull/68?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TuringLang) | Coverage Δ | | |---|---|---| | [src/LeaveOneOut.jl](https://codecov.io/gh/TuringLang/ParetoSmooth.jl/pull/68/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TuringLang#diff-c3JjL0xlYXZlT25lT3V0Lmps) | `84.48% <ø> (ø)` | | | [src/ModelComparison.jl](https://codecov.io/gh/TuringLang/ParetoSmooth.jl/pull/68/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TuringLang#diff-c3JjL01vZGVsQ29tcGFyaXNvbi5qbA==) | `86.79% <ø> (ø)` | | | [src/ImportanceSampling.jl](https://codecov.io/gh/TuringLang/ParetoSmooth.jl/pull/68/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TuringLang#diff-c3JjL0ltcG9ydGFuY2VTYW1wbGluZy5qbA==) | `79.34% <0.00%> (-0.88%)` | :arrow_down: | | [src/InternalHelpers.jl](https://codecov.io/gh/TuringLang/ParetoSmooth.jl/pull/68/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TuringLang#diff-c3JjL0ludGVybmFsSGVscGVycy5qbA==) | `69.23% <0.00%> (+1.23%)` | :arrow_up: | | [src/PublicHelpers.jl](https://codecov.io/gh/TuringLang/ParetoSmooth.jl/pull/68/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TuringLang#diff-c3JjL1B1YmxpY0hlbHBlcnMuamw=) | `68.42% <0.00%> (+1.75%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TuringLang). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TuringLang)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

ParadaCarleton commented 1 year ago

This is great, thanks @svilupp !