Closed github-actions[bot] closed 1 year ago
Patch and project coverage have no change.
Comparison is base (
118dd40
) 84.50% compared to head (53eb9b0
) 84.50%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Why was this merged? StatsBase 0.34 is not tested and can't be installed together with ParetoSmooth currently due to dependencies such as MCMCChains blocking it.
Why was this merged? StatsBase 0.34 is not tested and can't be installed together with ParetoSmooth currently due to dependencies such as MCMCChains blocking it.
I see, I didn't realize the tests weren't running with 0.34 because of MCMCChains. Is there a way to get CompatHelper or Github to check for this automatically?
It should fail automatically on newer Julia versions if something like this happens. Maybe it didn't because of the test/Project.toml file without compat entries?
BTW I am not convinced that there are any advantages compared to just adding test dependencies in Project.toml - on the contrary, with a test/Project.toml you have to duplicate dependencies and keep them in sync with Project.toml.
This pull request changes the compat entry for the
StatsBase
package from0.33.10
to0.33.10, 0.34
. This keeps the compat entries for earlier versions.Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.