TuringLang / ParetoSmooth.jl

An implementation of PSIS algorithms in Julia.
http://turinglang.org/ParetoSmooth.jl/
MIT License
19 stars 12 forks source link

use extensions instead of Requires on 1.9 #77

Closed KristofferC closed 1 year ago

KristofferC commented 1 year ago

This uses the new extension system in Julia 1.9 to avoid having to use Requires.jl which has a few issues.

I was a bit confused by the use of Requires in this package:

I changed this to how I think it is "reasonable" and tests seem to pass but please give it another set of eyes.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.21 :tada:

Comparison is base (118dd40) 84.50% compared to head (3e497c6) 84.71%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #77 +/- ## ========================================== + Coverage 84.50% 84.71% +0.21% ========================================== Files 11 11 Lines 400 399 -1 ========================================== Hits 338 338 + Misses 62 61 -1 ``` | [Impacted Files](https://app.codecov.io/gh/TuringLang/ParetoSmooth.jl/pull/77?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TuringLang) | Coverage Δ | | |---|---|---| | [src/InternalHelpers.jl](https://app.codecov.io/gh/TuringLang/ParetoSmooth.jl/pull/77?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TuringLang#diff-c3JjL0ludGVybmFsSGVscGVycy5qbA==) | `69.23% <ø> (ø)` | | | [ext/ParetoSmoothDynamicPPLExt.jl](https://app.codecov.io/gh/TuringLang/ParetoSmooth.jl/pull/77?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TuringLang#diff-ZXh0L1BhcmV0b1Ntb290aER5bmFtaWNQUExFeHQuamw=) | `100.00% <100.00%> (ø)` | | | [ext/ParetoSmoothMCMCChainsExt.jl](https://app.codecov.io/gh/TuringLang/ParetoSmooth.jl/pull/77?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TuringLang#diff-ZXh0L1BhcmV0b1Ntb290aE1DTUNDaGFpbnNFeHQuamw=) | `100.00% <100.00%> (ø)` | | | [src/ParetoSmooth.jl](https://app.codecov.io/gh/TuringLang/ParetoSmooth.jl/pull/77?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TuringLang#diff-c3JjL1BhcmV0b1Ntb290aC5qbA==) | `100.00% <100.00%> (+16.66%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.