Closed devmotion closed 1 year ago
Patch coverage: 50.00
% and project coverage change: -0.29
:warning:
Comparison is base (
25f28fe
) 84.28% compared to head (6fc0d1f
) 84.00%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
It won't be possible to keep running the full test suite with Turing on Julia 1.6 since Turing decided to drop support for Julia 1.6 - but only very ancient versions of it are compatible with MCMCChains 6 (they won't work but according to Project.toml at least).
I would suggest removing Turing from the tests completely - instead one could just save the output of a sample
run for all relevant model. The @model
s can still be defined since this only requires DynamicPPL - which has much less dependencies and hence fewer package conflicts and better Julia compat.
I would suggest removing Turing from the tests completely - instead one could just save the output of a sample run for all relevant model.
I will go with this option and update the PR accordingly.
Tests pass now, and the cached samples seem to yield similar results as the current runs on the master branch.
This PR updates the MCMCDiagnosticTools and MCMCChains compat entries and improves
relative_ess
.If you have time, maybe you could have a quick look @sethaxen since you implemented the recent improvements of
ess
in MCMCDiagnosticTools?Closes #73.