Closed itsdfish closed 1 year ago
Yes, I think a PR would be great. As I mentioned in that issue, the ideal situation is to change the interface for ParetoSmooth.jl (or potentially ArviZ.jl, which frankly is probably the better package for LOO-CV this at this point) to take as input both a model and a dataset, where the dataset should be given as an iterator over IID observations. Then, the algorithm proceeds by removing each data point from the dataset one at a time and calculating the appropriate LOO distribution.
Sounds good. I will submit a PR to update the documentation later this week or during the weekend.
Do you have plans for changing the interface?
Hi,
A few days ago on Discourse, someone described a problem with ParetoSmooth in which the wrong (or at least unexpected) sample size was used. It turns out this is related to an old issue already reported. For example, ParetoSmooth produces different results given two formally equivalent Turing models:
Model 1
Model 2
The only thing that differs is the use of a for loop. Unfortunately, this distinction was not clear and we wasted time trying to figure out the problem. Until a solution is added, I think it would be good to add an example explaining how to make a model work properly with ParetoSmooth. I would be willing to make a PR. Is it the case that for loop or
.~
is the recommended approach?