search

TuringLang / ParetoSmooth.jl

An implementation of PSIS algorithms in Julia.
http://turinglang.org/ParetoSmooth.jl/
MIT License
19 stars 12 forks source link

Fix `loo_compare` #92

Closed smith-garrett closed 4 months ago

smith-garrett commented 4 months ago

The minimal working example in #91 works now.

devmotion commented 4 months ago

IMO the better fix would be to replace Not with standard indexing.

smith-garrett commented 4 months ago

Ok, I've switched to using normal indexing. In the actual model comparison code, I used the axes() idea from #91. In the test code, I used normal 1:x indexing, as this seems to be safe with the RData objects used there.

devmotion commented 4 months ago

Thank you!