TuringLang / TuringCallbacks.jl

http://turinglang.org/TuringCallbacks.jl/
MIT License
13 stars 8 forks source link

Added Dates and updated docs #13

Closed jlperla closed 3 years ago

jlperla commented 4 years ago

The lack of Dates was causing trouble after your latest update. I also changed the docs to reflect the new default naming convention, which is great!

jlperla commented 4 years ago

Thank @torfjelde Essentially I was doing on the python stuff was making it fully consistent with the tensorboard and tensorboard for pytorch docs. For example, https://tensorboard.dev/#get-started and https://pytorch.org/docs/stable/tensorboard.html and virtually every other thing on the internet.

Your instructions didn't work for me, so I had to modify them. Maybe you have setup your python without using conda/etc.? My guess is that anyone who needs installation instructions will be using conda or a similar system.

... but this is your package. Do as you like. I don't have strong opinions except just trying to copy what other people have done with beginner instructions and python.

jlperla commented 4 years ago

@torfjelde Can I suggest that you modify the doc as you see fit, or toss out all of my changes if you don't like them, and then merge? I don't think we need to discuss it further, as you can modify the way you like it. The only thing I wanted to get across in my repsonses was that I think you have a different python setup than most introductory people would, especially given that people frequently use conda and (hopefully!) are using virtual environments whenever possible. python is impossible otherwise.

Later you might want to install tensorboard with Conda.jl if people have it installed.

torfjelde commented 4 years ago

The only thing I wanted to get across in my repsonses was that I think you have a different python setup than most introductory people would

And thank you for bringing this to my attention! I thought what I had written up was the lowest common denominator for the different setups, but it indeed seems like it's not the case. I'll likely keep a lot of what you added :+1:

jlperla commented 4 years ago

@torfjelde Sounds great. But don't feel obligated. I could be wrong :-)

Would love it for the package to be registreed sooner than later, which makes it easier to add as a package dependency.

jlperla commented 4 years ago

The documetnation updates here are not cruciail, but is it possible to make this into a registered package? It is otherwise hard to use as a dependency for packages.

torfjelde commented 3 years ago

Just a heads up @jlperla ; it's registered now:) Sorry about the delay.

jlperla commented 3 years ago

Great, thanks!