search

TuringLang / docs

Documentation and tutorials for the Turing language
https://turinglang.org/docs/
MIT License
231 stars 99 forks source link

Rename and reorder tutorials #273

Closed ParadaCarleton closed 2 years ago

ParadaCarleton commented 3 years ago

@cpfiffer not sure what's off; looks like renaming the folders broke something?

devmotion commented 3 years ago

I am not sure didn't we discuss some potential renaming (in a different way and for a different reason?) in the refactoring PR? With some folder Is that already fixed? Also it seems the names of the folders and files (already on master) are a bit redundant and inconsistent - we have a NN_name.jmd file in a NN-name folder. Maybe this could be simplified?

rikhuijzer commented 3 years ago

The failing tests are my bad and I'm looking into it.

Nice find for the redirect_from. However, if I'm not mistaken the syntax should probably be like the example in the jekyll-redirect-from docs:

title: My amazing post
redirect_from:
  - /post/123456789/
  - /post/123456789/my-amazing-post/
review-notebook-app[bot] commented 3 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

ParadaCarleton commented 3 years ago

@rikhuijzer uhh, hmm, looks like the tests failed again and I'm not sure why?

rikhuijzer commented 3 years ago

@rikhuijzer uhh, hmm, looks like the tests failed again and I'm not sure why?

Because there are errors, that is, the logs for the tutorials contain "ERROR" a few times. The first two are for tests, but the last ones are for tutorials. This is checked by

https://github.com/TuringLang/TuringTutorials/blob/17d665dd1bc51e50547f495f0ef28fdfcf5cecdb/src/build.jl#L2-L10

You can debug locally and see what the error is by running

using TuringTutorials

build_and_exit(changed_tutorials())
yebai commented 2 years ago

Closed in favour of https://github.com/TuringLang/TuringTutorials/pull/280