search

TuringLang / docs

Documentation and tutorials for the Turing language
https://turinglang.org/docs/
MIT License
229 stars 99 forks source link

Run tutorials on Julia 1.7 #295

Closed rikhuijzer closed 2 years ago

rikhuijzer commented 2 years ago

@devmotion Is this the place to change the Julia version to 1.7?

devmotion commented 2 years ago

Yes, but there's one other line to update in this file.

However, I think it is a bit easier and requires fewer updates and rebuilds if we just use Julia LTS (i.e., keep using Julia 1.6). If the version is changed, we also have to update all Manifest files (IIRC 1.7 introduced a slightly different format) and most importantly have to update the cryptographic signature (it prevents any "random" PRs from changing the important parts of the buildkite setup, IIRC it can only be done by buildkite administrators).

rikhuijzer commented 2 years ago

However, I think it is a bit easier and requires fewer updates and rebuilds if we just use Julia LTS (i.e., keep using Julia 1.6).

I fear that people then might conclude that Turing shouldn't be used on Julia 1.7 or that Julia 1.7 shouldn't be used even though the opposite is true. The 1.8 beta even shows 10% reduction in TTFX in many cases is what I've noticed during benchmarks

devmotion commented 2 years ago

I fear that people then might conclude that Turing shouldn't be used on Julia 1.7 or that Julia 1.7 shouldn't be used even though the opposite is true.

What makes you think that users would assume this? I would have guessed most not even look at the system information but only if they can't rerun the tutorials. And otherwise just try to install Turing with whatever Julia version they use (and hence I think it might be more likely that they use a too old Julia version and hence Turing is hold back which in turn causes problems). We never state explicitly anywhere which Julia versions are supported (maybe we should and mention that LTS and all more recent Julia versions are supported?).

The 1.8 beta even shows 10% reduction in TTFX in many cases is what I've noticed during benchmarks

Since we run tutorials only once I don't think the hazzle of updating the packages and CI to new Julia versions is worth it. E.g., we also don't rerun the tutorials if newer non-breaking package versions are released.

rikhuijzer commented 2 years ago

Whatever. I'm not here to have arguments. I leave the decision up to you