search

TuringLang / docs

Documentation and tutorials for the Turing language
https://turinglang.org/docs/
MIT License
229 stars 99 forks source link

Abort build process when error occurs #303

Closed devmotion closed 2 years ago

devmotion commented 2 years ago

This should make it less likely to miss if a tutorial is broken. Without any options specified, Weave will just continue and include the error in the output. With this PR, Weave will throw an error instead and abort the build process.

Currently, the option is only specified for the hidden chunks with assertions but I think it's useful to set it for all chunks.

rikhuijzer commented 2 years ago

Nope sorry I'm done with Weave. I've built this kind of logic in PlutoStaticHTML.jl to get rid of this kind of logic in the TuringTutorials repository. I'm not spending time to figure out again how to make CI fail on error.

devmotion commented 2 years ago

I'm not spending time to figure out again how to make CI fail on error.

Nothing to do for you here, it's an option in Weave and this PR enables it for all chunks :slightly_smiling_face: Just thought you might like it and approve the PR.