search

TuringLang / docs

Documentation and tutorials for the Turing language
https://turinglang.org/docs/
MIT License
231 stars 99 forks source link

Add tutorial on time series modelling #307

Closed SebastianCallh closed 2 years ago

SebastianCallh commented 2 years ago

Please let me know if you have any comments or suggestions before merging. I could not run weave the file as described in the readme (it just got stuck forever) but I tested all the code in the REPL so it should work.

In the issue I describe working with the air passengers data set, but I couldn't find a nice way to load it into the tutorial so to avoid the problem altogether I opted for synthetic data,

Closes #306.

staticfloat commented 2 years ago

I'm not sure why buildkite does not run the tutorial, maybe it doesn't run for PRs from forks @staticfloat?

Indeed. If you want that, go into the buildkite admin settings, under GitHub and check the appropriate box:

image
devmotion commented 2 years ago

Thanks! I enabled it for PRs from forks conditional on a "buildkite" label.

SebastianCallh commented 2 years ago

Thank you for the great suggestions @devmotion, very thorough review! I'm quite busy during the weekend but will address them early next week.

SebastianCallh commented 2 years ago

Thanks again for your comments @devmotion ! I have updated the PR accordingly, with a few exceptions which I motivate in your the relevant comments.

I see buildkite is crashing with ERROR: LoadError: The manifest file you are using was most likely generated by a different version of Julia and is not compatible with this Julia version when it tries to run the code under Julia 1.6 (I am indeed using a different version, 1.7.3). How do you suggest we proceed?

devmotion commented 2 years ago

Can you recreate the Manifest file with Julia 1.6? That would fix the issue.

SebastianCallh commented 2 years ago

Fixed!

SebastianCallh commented 2 years ago

My pleasure @yebai ! Thank you for your work on Turing!