search

TuringLang / docs

Documentation and tutorials for the Turing language
https://turinglang.org/docs/tutorials/docs-00-getting-started/
MIT License
225 stars 97 forks source link

Yongchao/pp pca update #364

Closed YongchaoHuang closed 1 year ago

YongchaoHuang commented 1 year ago

Followup of https://github.com/TuringLang/TuringTutorials/pull/348

yebai commented 1 year ago

@YongchaoHuang can you resolve the git merge conflict, and remove the edits to BayesianDiffEqs, please?

storopoli commented 1 year ago

@yebai just hold this until Sunday? I am planning to have a quick review over the weekend.

YongchaoHuang commented 1 year ago

@storopoli Thanks a lot Jose for the nice review and helpful suggestions - I will have a look and respond ASAP.

YongchaoHuang commented 1 year ago

@storopoli Thanks very much for the guidance - this is really good practice, I am looking at it.

YongchaoHuang commented 1 year ago

@storopoli @yebai I just fixed one bug which leads to long sampling time (I forgot to transpose mat_exp when instantiating 'pPCA_ARD(mat_exp)'). Then I run all Julia blocks and it works now - for the two blocks involving NUTS sampling, each takes less than 10 mins to run. I have not weaved the whole .jmd on my local machine - I just successfully tested the Julia blocks. I think it is improved a lot with Jose's corrections on math symbols. Would it be possible for you guys to have a quick (hopefully final) review, then we can merge it into master? Thanks ahead.

storopoli commented 1 year ago

@yebai it is up to you. I have not checked the code thoroughly, just the model syntax and the text (math, punctuation and typos).

yebai commented 1 year ago

Let's see whether @devmotion is also happy. He worked on this tutorial sometime ago.

YongchaoHuang commented 1 year ago

@storopoli @devmotion @yebai Thanks a lot for your comments, suggestions and help for improving this PR, I guess most, if not all, of the concerns have been addressed and problems solved. The weaved html looks good - ready to merge?

yebai commented 1 year ago

Many thanks, @YongchaoHuang, for the nice improvements! I am merging this now as the version on the docs website is broken and will benefit from this PR.

YongchaoHuang commented 1 year ago

@yebai Great. We can always improve it in the future if necessary.

storopoli commented 1 year ago

@YongchaoHuang congratulations! Good work!

YongchaoHuang commented 1 year ago

@storopoli Many thanks for your help along the journey!