TuringLang / docs

Documentation and tutorials for the Turing language
https://turinglang.org/docs/
MIT License
229 stars 99 forks source link

[buildkite] Update S3 credential handling #416

Closed staticfloat closed 1 year ago

staticfloat commented 1 year ago

We were alerted that our S3 credentials had leaked in a build that dumps the environment when it errors out [0]. This PR rotates to a new key, and also wipes out the key in the environment during the build itself, so that important values won't get written out in debugging information like that.

[0] https://github.com/SciML/SciMLBenchmarksOutput/blob/8d80b1840228c63e8c6fdc597049211a8b916dea/markdown/DynamicalODE/single_pendulums.md

staticfloat commented 1 year ago

Looks like it's working!