Closed JasonPekos closed 1 month ago
I think maybe this should be closed and revisited when https://github.com/TuringLang/TuringTutorials/pull/441 is done?
fwiw the current thing that's keeping this frozen is the multithreading stuff. If we want to stay away from:
chains = sample(model, sampler, MCMCThreads(), nsamples, nchains; discard_initial = burn);
to avoid warnings in single threaded environments, we'll need to update a bunch of tutorials, because this is pretty common across all the tutorials.
Thanks, @JasonPekos, for the PR. Would you like to migrate your changes here to #441?
Thanks, @JasonPekos, for the PR. Would you like to migrate your changes here to #441?
Yup, will do.
First PR! Hope everything is ok.
As discussed in the slack, this PR adds the following significant changes to this tutorial
ordered()
fromBijectors.jl
in making the model identifiable (currently it is multimodal, and the seed is just lucky.)Turing.@addlogprob!
~ MixtureModel(dists, weights)
generated_quantities()
There are also a few minor changes: