TuringLang / docs

Documentation and tutorials for the Turing language
https://turinglang.org/docs/tutorials/docs-00-getting-started/
MIT License
225 stars 97 forks source link

Substantial updates to tutorial 01_gaussian-mixture-model #439

Closed JasonPekos closed 1 month ago

JasonPekos commented 2 months ago

First PR! Hope everything is ok.

As discussed in the slack, this PR adds the following significant changes to this tutorial

There are also a few minor changes:

JasonPekos commented 1 month ago

I think maybe this should be closed and revisited when https://github.com/TuringLang/TuringTutorials/pull/441 is done?

fwiw the current thing that's keeping this frozen is the multithreading stuff. If we want to stay away from:

chains = sample(model, sampler, MCMCThreads(), nsamples, nchains; discard_initial = burn);

to avoid warnings in single threaded environments, we'll need to update a bunch of tutorials, because this is pretty common across all the tutorials.

yebai commented 1 month ago

Thanks, @JasonPekos, for the PR. Would you like to migrate your changes here to #441?

JasonPekos commented 1 month ago

Thanks, @JasonPekos, for the PR. Would you like to migrate your changes here to #441?

Yup, will do.