TuringSoftware / CrystalFetch

macOS UI for creating Windows installer ISO from UUPDump
Apache License 2.0
627 stars 23 forks source link

esd2iso.sh does not work with `dash` (is not POSIX) #39

Closed ilyagr closed 5 months ago

ilyagr commented 8 months ago

I experienced the following error:

Screenshot 2024-01-12 at 3 02 14 PM

I'm guessing this is because my /private/var/select/sh symlink points to dash as opposed to bash.

Indeed, pasting the esd2iso.sh script into www.shellcheck.net reveals a bunch of errors, most notably that declare and arrays are not part of POSIX sh.

You could either fix these issues, or you could change the shebang to /bin/bash.

Update: I changed the shebang in my CrystalFetch.App archive from /bin/sh to /bin/bash, and it seems that everything started to work.

Update 2: Another option might be to upgrade to https://github.com/Technogeezer50/esd2iso. It uses /bin/bash explicitly.