TuringSoftware / CrystalFetch

macOS UI for creating Windows installer ISO from UUPDump
Apache License 2.0
627 stars 23 forks source link

Escape sequences not properly removed from UI string #9

Closed wjk closed 1 year ago

wjk commented 1 year ago

Consider the following screenshot.

Screenshot 2023-08-04 at 2 11 08 PM

You can see at the bottom that the status message contains [1;94m and [0m tokens. These are shell escape sequences to change the color of output text. (The leading Escape character is probably still there, too; it just doesn’t render as anything.) With all other text that appears in that field, any escape sequences that might have been there were stripped, as they should be because we’re not a terminal app. This step and the “Done” text immediately following are the only strings in the app that exhibit this bug.

osy commented 1 year ago

Yeah, I thought about it but I wrote this in 2 days and didn't feel like putting in the effort lol. Maybe someone else can contribute a fix...