search

TurkServer / meteor-tutorials

Create super cool animated tutorials for your Meteor app.
MIT License
103 stars 21 forks source link

i18n and "skip tutorial" #4

Open guidouil opened 10 years ago

guidouil commented 10 years ago

Hi Mizzao, First, thanks for your great package, I'm using it on gotlog.in (question mark in the nav bar) and it's great :+1: Now my questions :8ball: are you planning to integrate the mutli language with i18n ? https://atmospherejs.com/tap/i18n

And also (I hate when people ask 2 questions in 1 issue ^^ ). Is there a way in the tutorial to have the close button (x) on top right of the tutorial window ?

And also, the annimation was not displaying ok on smartphones so I forced the size and position. thanks for your "positioned" class :)

.positioned { max-width: 350px; left: 10px!important; margin-left: 0!important; }

mizzao commented 10 years ago

Hi @guidouil, I would happily accept a PR that has a weak dependency on that (if it's the best option for i18n right now) and uses it to display text.

Having the close button is a reasonable request, it would probably trigger a new onClose callback or something.

By forcing the size/position, you mean it doesn't animate anymore, right?

guidouil commented 10 years ago

Ok for the PR, will do. I would like the closing in the config, showCloseButton: true Yes it disables the animation =( maybe it would be better only in mobile but I don't know how to do it in css. You can close this "issue". Thanks for your time