search

TurkeyMan / color

Development for std.color
14 stars 6 forks source link

dub: Switch default target type from sourceLibrary to library? #16

Closed nordlow closed 9 months ago

nordlow commented 10 months ago

Would it be possible to somehow integrate

https://github.com/symmetryinvestments/color/commit/c309b30bdd9359d1499b0286eeec4c1c426560ba

upstream into TurkeyMan/color?

Or can reggae by adjusted to support

"targetType": "sourceLibrary"

so we don't need to maintain the fork https://github.com/symmetryinvestments/color

, @atilaneves?

FYI, @kinke.

TurkeyMan commented 10 months ago

Make a PR and I'll click the button :)

nordlow commented 10 months ago

I'm getting the error

Pull request creation failed. Validation failed: must be a collaborator

when trying to create the PR in the web ui of gitlab. Is this error message specific to web interactions?

nordlow commented 10 months ago

I'm getting the error

Pull request creation failed. Validation failed: must be a collaborator

when trying to create the PR in the web ui of gitlab. Is this error message specific to web interactions?

Seems like that is the case because I managed to make the PR by pushing a locally created branch resulting in https://github.com/TurkeyMan/color/pull/17.

nordlow commented 9 months ago

Accompanying tags on both github and code.dlang.org are very welcome.