search

TurnWheel / jReject

jQuery Browser Rejection Plugin
http://jreject.turnwheel.com/
277 stars 98 forks source link

Detecting Chrome 26 on iOS as `safari` #28

Closed eoinoc closed 11 years ago

eoinoc commented 11 years ago

Using jReject 1.0.2 with jQuery 1.8.2.

The issue is that Chrome v26 on iOS seems to be detected as safari.

I have the following option when calling jReject:

reject: {
    // basically, just allow Chrome
    firefox: true,
    safari: true,
    msie: true,
    opera: true,
    konqueror: true,
    unknown: true,
}

When visiting that past with Chrome v26 on iOS, it gets rejected. The value for $.browser.name is set to safari.

BluSyn commented 11 years ago

Unfortunately Chrome for iOS uses very similar identification as Safari for iOS, which is why it appears to be the same. They also both use basically the same renderer (for now anyway).

I am working on a way to distinguish between the two. Will notify you when I have a patch for this.

asentner commented 11 years ago

Chrome is being blocked on iOS even if all: false with nothing else defined.

BluSyn commented 11 years ago

Latest commit should fix your issue. With the latest version, Chrome for iOS now reports as Chrome v26.0.1410.50.

Previously it was incorrectly reported as Safari 2.0

eoinoc commented 11 years ago

Nice work :+1:

Might I suggest an incrementing the release version?

asentner commented 11 years ago

I concur. I patched mine with the latest deltas and will confirm my problem is resolved. Thanks!