TurtIeSocks / Koji

Geofence manager and route creator
https://koji.vercel.app
MIT License
26 stars 5 forks source link

Numeric Geofence names cause nightmare situation - DO NOT TRY WITHOUT READING #220

Open comstud opened 9 months ago

comstud commented 9 months ago

Creating a geofence and using a name that is only numbers will replace an existing record with that geofence id.

(For the record, I don't want only numeric names.. I just discovered this by chance. It'd be fine if the fix was to disallow them.)

Thank goodness for db backups, eh?

Steps to reproduce in admin interface:

1) Find or create a geofence you don't care to lose. Go edit it and grab id from url. Pick a normal name for this one. 2) To make it easy to spot the issue later: Find or create a 2nd geofence, also with a normal name, and set the geofence in Step 1 as the parent. In list of geofences, you'll see the geofence in Step 1 as the parent for this new one. 3) Now the fun: Create a new geofence. For the name, use the id from Step 1. Save it. 4) Look around at your geofences. The geofence in Step 1 looks gone. The geofence in Step 2 will have the new geofence as parent, showing that the new fence received the same id as what was created in Step 1.

NOTE: renaming an existing geofence to one that has all numbers does not seem to be a problem.