Project Discussion

[corytortoise]

Project Discussion

Let's use this issue to discuss anything project-related, including quick questions, contribution discussion, etc. For other issues, please make a separate issue in the tracker to prevent confusion.

[corytortoise]

Considering the amount of people that want to contribute, I believe we need to make a consensus on contribution guidelines. I suggest we use the same code formatting as PMMP, but I am open to any suggestions.

[jasonw4331]

This plugin is going to be a lot bigger a deal than I had anticipated

[ghost]

Can i put my own version here? Just to test it out and improves it?

[jasonw4331]

@imjayl you already have a version that works?

[ghost]

@jasonwynn10 Yes its easy to customize but the only problem is i didnt add the gold spawn thing

[jasonw4331]

link?

[ghost]

View your message at pmmp forum :)

[xBeastMode]

@jasonwynn10 can you create a proper issue with the total list of features?

[Kris-Driv]

Put @imjayl code into separate branch.

[jasonw4331]

He asks that the code is not to be made public, so we won't be able to copy it explicitly, but I think we may be able to use it as an example.

[Kris-Driv]

Also, make sure that we don't make too much code changes per commit. In project like this and at this stage, it can cause file conflicts a lot.

[corytortoise]

@Chris-Prime I agree.

[xBeastMode]

And if it's possible please use Git, it will automatically sync the repository for you, then you can do your part and commit it.

[jasonw4331]

I won't be able to really code very much until I can get my computer repaired, but I will be using PhpStorm once I do, so you all shouldn't have anything to worry about.

[Kris-Driv]

Main class name seems too plain, what about Launcher or MurderMystery?

[xBeastMode]

MurderMystery is good.

[Kris-Driv]

At some point we'll need to implement language files. What's your opinion on using namespace function which would look like this

namespace TurtleTeam\MurderMystery;

function lang(string $key, ...$params): string {
   return Foo::getInstance()->getMessage($key, $params);
}

class Foo {

   public function onEnable() {
      $this->getLogger()->info(lang("plugin-enabling"));
   }
}

[xBeastMode]

I guess it's good but I think we should make it static final just for security.

[Sandertv]

People, is this plugin still going to be continued? I can do all the bodies part and stuff if you want.

[jasonw4331]

I have my own project running separately which has made more progress... I'm pretty sure this is discontinued, but if the others feel like working on it, they may feel free to do so

[corytortoise]

If somebody wants to take over ownership, let me know. I'm not worthy or or knowledgable enough to oversee this.