Tutislav / neodeemer

Spotify/YouTube song downloader with option to download whole albums, playlists and also lyrics. Available on Android, Windows and Linux.
GNU General Public License v3.0
36 stars 2 forks source link

[BUG] Replacement strings in filenames for special characters #3

Closed xamionex closed 6 months ago

xamionex commented 6 months ago

By accident I stumbled upon this image Which made me think it'd probably tried doing ** in the filename which just removed them ;p Dunno how'd you avoid this but I was thinking __ or some unicode

Tutislav commented 6 months ago

Some characters like * or ? are forbidden in filenames on Windows so I just filtered filename to alphanumerical characters only. Anyway when you play it in any music player, it should display the right name, because it's saved as tag to file.

xamionex commented 6 months ago

Some characters like * or ? are forbidden in filenames on Windows so I just filtered filename to alphanumerical characters only. Anyway when you play it in any music player, it should display the right name, because it's saved as tag to file.

Yeah I know, but it looks really weird without anything replacing it, so I was thinking of just replacing it but your solution makes sense after looking at metadata, you can close if you want