search

Tuurlijk / typo3scan

Scans TYPO3 extensions for usage of deprecated and or changed code
MIT License
94 stars 17 forks source link

Add the property annotation matcher to the scan #34

Closed AlexRitty closed 4 years ago

AlexRitty commented 4 years ago

In the MichielRoos\TYPO3Scan\Service\ScannerService class, the matcher Matcher\PropertyAnnotationMatcher::class is missing.

Tuurlijk commented 4 years ago

Can you provide a patch?

AlexRitty commented 4 years ago

Sorry, I did not manage to compile the .phar with the last typo3scan version. So I didn't propose any patches. But I noted that the V9 matcher list in your ScannerService is note up to date. The PropertyAnnotationMatcher is Missing.

https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail Garanti sans virus. www.avast.com https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail <#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>

Le dim. 29 mars 2020 à 15:19, Michiel Roos notifications@github.com a écrit :

Can you provide a patch?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Tuurlijk/typo3scan/issues/34#issuecomment-605634542, or unsubscribe https://github.com/notifications/unsubscribe-auth/AN3SIIO5WJO47FP6SJKHJ73RJ5DHJANCNFSM4KTWEAZA .

Tuurlijk commented 4 years ago

You should be able to run the code without building a phar file as noted here: https://github.com/Tuurlijk/typo3scan#run-the-typo3scan-tool

Tuurlijk commented 4 years ago

You mean in the bundle definition!

Tuurlijk commented 4 years ago

Fixed. Thx for reporting. New release is out