search

TuvaLabs / markdown-delight-editor

A markdown editor
7 stars 1 forks source link

Add the spell check for the markdown editor (codemirror) #8

Open jpatel3 opened 5 years ago

jpatel3 commented 5 years ago

Add spell check/default or option to click - https://www.npmjs.com/package/codemirror-spell-checker

jpatel3 commented 5 years ago

Markdown Spellcheck

benfarahmand commented 5 years ago

Tested in sandbox.tuvadata.com, works well. Any plan to add it on tuvalabs and other subdomains?

jpatel3 commented 5 years ago

It should be on other subdomains, not on tuvalabs or any other tuvalabs subdomain. It will take some time.

On Thu, May 9, 2019 at 12:42 PM Benjamin Farahmand notifications@github.com wrote:

Tested in sandbox.tuvadata.com, works well. Any plan to add it on tuvalabs and other subdomains?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/TuvaLabs/markdown-delight-editor/issues/8#issuecomment-490979098, or mute the thread https://github.com/notifications/unsubscribe-auth/AAKM7LC2ECVIUVYSF6DTYN3PURH7XANCNFSM4HE743KA .

-- Jaimin

benfarahmand commented 5 years ago

So, close this for now? Or keep it open until it's added to tuvalabs as well?

jpatel3 commented 5 years ago

we can close it part of markdown editor. But keep that card in trello for Tuva. No need for ticket for now.

On Thu, May 9, 2019 at 1:05 PM Benjamin Farahmand notifications@github.com wrote:

So, close this for now? Or keep it open until it's added to tuvalabs as well?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/TuvaLabs/markdown-delight-editor/issues/8#issuecomment-490986860, or mute the thread https://github.com/notifications/unsubscribe-auth/AAKM7LD7CJU6MMZYHRSPY4DPURKWRANCNFSM4HE743KA .

-- Jaimin

jpatel3 commented 5 years ago

@naveenkumarganesan Probably this is better solution than by default adding checker - https://github.com/TryGhost/Ghost-Admin/pull/697/files/a7debf6c1f79ee0ea8d9e01fc21311323ebb659d

I'll try out removing the spell check brings back the color and style changes, if yes, will go for explicit button.