search

Tux / App-ccdiff

A colored diff that also colors inside changed lines
Artistic License 2.0
18 stars 5 forks source link

Remove diff-so-fancy symlink to nonexistent file #23

Closed ryandesign closed 2 years ago

ryandesign commented 2 years ago

This removes Talk/diff-so-fancy, which was a symlink to the nonexistent file diff-so-fancy-git/diff-so-fancy.

This broken symlink was added in 2b0e36292d91897af94f0df25eb5f2b5c60aa1fb along with a another broken symlink called klondiff. The klondiff symlink was already removed in c645433d07e914c3ee70f346f4b37d83a20c1d9c (though that's not mentioned in the commit message).

ryandesign commented 2 years ago

Please leave Talk/ as-is

As you wish, however:

Talk is not in the distribution

I guess when you say "the distribution" you're referring to what's on CPAN. But Talk is in the repository and, like everything else in the repository, it is present in archives that are downloaded from GitHub, like this one:

https://github.com/Tux/App-ccdiff/archive/refs/tags/0.31.tar.gz

What caused me to notice the problem was that I was doing recursive greps within your repository; each time, I would get a warning about the broken symlink.

To me, it is strange to consider it correct to keep broken symlinks in the repository. If on your system the symlink points to something useful that is not in the repository, then maybe it makes more sense for you to keep the symlink local to your system too (and not in the repository).

Tux commented 2 years ago

Yes, you're right, and I am working on it (.gitignore and such), but recovering from Covid, so time flows in all different directions. Thanks for noticing and paying attention. All your remarks made sense

Tux commented 2 years ago

Now integrated in current repo. Should be clean now