Tux / Spreadsheet-Read

Meta-Wrapper for reading spreadsheet data with perl5
15 stars 17 forks source link

Pull request challange - small improvements #22

Closed happy-barney closed 6 years ago

Tux commented 6 years ago
  1. Typoes: thank you, applied and pushed
  2. List::Util. Will have to think about that one. It is elegant, but does not do the same as the original code. The original code removes the file argument from the list. The list is later used in the last call, so that removal is vital.
  3. Support input option: I like it. Applied and pushed
  4. Perl version. That needs a lot more testing. I had something similar in before, but something broke, so there will be or might have been situations where that didn't work
  5. No new tests?

Thanks for your interest

happy-barney commented 6 years ago

two commits applied, two no so good