search

Tux / Text-CSV_XS

perl5 module for composition and decomposition of comma-separated values
17 stars 20 forks source link

fix skip_empty_rows('skip') and trailing newlines #52

Closed bugfood closed 1 year ago

bugfood commented 1 year ago

When reading line by line, Text::CSV_XS returns an empty row if the input file contains an empty line, even if skip_empty_rows('skip') is in use.

The mechanism for this is substantially the same as is decribed in the corresponding PR for Text::CSV: https://github.com/makamaka/Text-CSV/pull/65

This fixes: https://github.com/Tux/Text-CSV_XS/issues/51

bugfood commented 1 year ago

I'm not sure if this PR covers all the edge cases for embedded CR and LF; the commit does fix at least the simple bug I ran into.

bugfood commented 1 year ago

Thank you!

bugfood commented 1 year ago

Could you please release version 1.53 some time soon? I think that is necessary in order to make CI tests in Text::CSV work.

https://github.com/makamaka/Text-CSV/pull/65#issuecomment-1821210962

Thank you, Corey

Tux commented 1 year ago

It is planned, but some other issues open with other major modules (like DBI) eat my time. Just be patient.

FYI: a standard release of Text::CSV_XS with all tests takes about 4 hours

bugfood commented 1 year ago

That's fine. I didn't mean to pester--I just thought maybe I had to request it.

Thanks for the work on this.