rhythmbox-ampache (possible) update for Rhythmbox 2.95 (and up)

[GoogleCodeExporter]

I've tried to update the rhythmbox-ampache plugin to be used in Rhythmbox 2.95 
(and up) and would like to provide my changes in the attached patch for review 
and possibly a new branch in this repository.

I based the plugin on HEAD of this repository but used various parts/ideas from 
the now dysfunct Magnatunes plugin. Major changes are:
- GSettings are used for storing plugin preferences.
- The preferences GUI has been updated. The server url takes now the ampache 
root and omits the server/xml.server.php extension.
- Refetching is done through the context menu of the entry. The xml file 
downloaded from the server is used directly as cache file.
- The xml is parsed using sax.

Things I'm not too happy about and will need to be changed:
- rhythmbox entry_delete_by_type() results in an entry->refcount > 0 assertion 
and Segmentation Fault and therefore do_deactivate() leaves this call out; 
refetch will cause a Segmentation Fault at this moment because of that
- I would have liked to use Gio for writing the cache file (I use it for 
downloading the songs information and loading the cache file) but write_async 
seems to cause garbage at the beginning of each chunk; I'm using python file 
I/O as a workaround
- I haven't touched the README file

I'm using the plugin myself successfully at the moment.

For information: I've sent in a patch to ampache that should accelerate the xml 
API songs download to make this plugin more attractive to use.

Any comments are of course very welcome.

Original issue reported on code.google.com by lotan...@gmx.de on 9 Feb 2012 at 9:22

[GoogleCodeExporter]

fixed some indentation issues

Original comment by lotan...@gmx.de on 9 Feb 2012 at 9:47

Attachments:

• rhythmbox-ampache-gtk3.patch

[GoogleCodeExporter]

You now have commit rights

Original comment by s...@epsteyn.com on 9 Feb 2012 at 11:17

[GoogleCodeExporter]

Original comment by s...@epsteyn.com on 9 Feb 2012 at 11:17

[GoogleCodeExporter]

I would like to test this however when running setup.py I get this error

error: can't copy "org.gnome.rhythmbox.plugin.ampache.gschema.xml' : doesn't 
exist or not a regular file.

Is there some place I can get this file?  It seems these changes have never 
been commited to svn.

Original comment by porthose...@gmail.com on 17 Apr 2012 at 5:56

[GoogleCodeExporter]

The patch has been committed to svn see:

   /svn/branches/for_rhythmbox-gtk+3

Original comment by lotan...@gmx.de on 17 Apr 2012 at 8:46

[GoogleCodeExporter]

lol thank I was not aware of that branch.  Install when flawlessly however when 
I go to use the plugin I get this error:

DBusError org. Freedesktop.DbussError: No Reply.  Did not recieve a reply.  
Possible causes include : the remote app did not send a reply, the message bus 
security policy blocked the reply, the reply timeout expired or the network 
connection was lost.

Any suggestions on what might be causing this.  I ran my tests on Ubuntu 
precise and Debian wheezy.

Original comment by porthose...@gmail.com on 18 Apr 2012 at 9:51

[GoogleCodeExporter]

here is the output from rhythmbox -D ampache

charlie@debian:~$ rhythmbox -D ampache

(rhythmbox:2186): Rhythmbox-WARNING **: Unable to grab media player keys: 
GDBus.Error:org.freedesktop.DBus.Error.UnknownMethod: No such interface 
`org.gnome.SettingsDaemon.MediaKeys' on object at path 
/org/gnome/SettingsDaemon/MediaKeys
(05:25:39) [0x8fc6660] [AmpacheBrowser.update_catalog] 
/usr/lib/rhythmbox/plugins/ampache/AmpacheBrowser.py:603: downloading 
handshake: 
http://192.168.1.101/ampache/server/xml.server.php?action=handshake&auth=104664e
898634f72f54711ac1484a26bd4d530269d1bd5a57e589f30c9184b8f×tamp=1334831139&user=
admin&version=350001
(05:25:55) [0x8fc6660] [AmpacheBrowser.download_songs_chunk] 
/usr/lib/rhythmbox/plugins/ampache/AmpacheBrowser.py:481: downloading songs: 
http://192.168.1.101/ampache/server/xml.server.php?action=songs&auth=61029b99cf5
eba88245699b76e19e028&offset=0&limit=15000
charlie@debian:~$ 

Original comment by porthose...@gmail.com on 19 Apr 2012 at 10:36

[GoogleCodeExporter]

The Warning you're experiencing seems to originate from the mmkeys (Media 
Player Keys) plugin which is builtin to Rhythmbox.
Maybe something went wrong in the installation or rhythmbox itself hasn't quite 
finished porting the plugin.
What's surprising me is that it looks like the warning is fatal.

The debug messages for AmpacheBrowser are fine as far as you posted them 
(except for the limit value is originally set to 5000 not 15000 but you might 
have had a copy&paste slip).

Original comment by lotan...@gmx.de on 19 Apr 2012 at 4:13

[GoogleCodeExporter]

yep you were right, was missing a couple dependencies.  Works GREAT.  Could you 
possible release a *.tar.gz (or at least commit these changes to trunk) so I 
can upload it to Ubuntu Precise before final freeze?

Original comment by porthose...@gmail.com on 22 Apr 2012 at 8:53

[GoogleCodeExporter]

Sorry for the late reply, email got stuck in spam filter.

Glad to hear that it's working for you.
I don't necessarily want to merge to trunk because I think there are a few 
people still using rhythmbox 0.13.x which is covered by trunk.

You've obviously installed the plugin successfully, why don't you generate a 
tarball yourself? (svn export)

Original comment by lotan...@gmx.de on 10 May 2012 at 9:16