TuxedoTako / 4chan-xt

Adds various features to anonymous imageboards.
Other
110 stars 8 forks source link

Safari on maxOS does not render all header bar emojis #38

Closed Alen3000 closed 5 months ago

Alen3000 commented 6 months ago

At a quick glance this includes:

Additionally, the emojis seem have to varying sizes.

image

Appreciate that Font Awesome is bloat, but it may not be an unreasonable use case to inline some simple, sensibly licensed SVG icons or similar, or finding some other, better way of normalising sizes.

saxamaphone69 commented 6 months ago

Perhaps emoji/unicode icons need a specific font stack to ensure consistent rendering. 'Apple Color Emoji', 'Segoe UI Emoji', 'Segoe UI Symbol', 'Noto Color Emoji' somewhere? Though when an emoji version doesn't exist, I dunno.

TuxedoTako commented 6 months ago

On windows, the emoji are from Segoe UI Symbol, Segoe UI Emoji is for multi colored pictures instead of the symbols in the fonts color.

I don't have an apple device to test on, so I can't check what font stack would have that effect on mac.

Alen3000 commented 6 months ago

At a glance it seems like it's just inheriting the font-family from whatever theme is picked, by default the yotsuba themes use font-family: arial, helvetica, sans-serif.

Setting font-family: 'Apple Color Emoji', 'Segoe UI Emoji', 'Segoe UI Symbol', 'Noto Color Emoji' seems to only really make the reply icon appear more consistent by using a coloured emoji:

When trying to use the characters elsewhere in the system they don't seem to render nicely either. Perhaps it may be worth considering alternative characters, if you don't fancy embedding icons?

Could consider setting the font family as per https://github.com/TuxedoTako/4chan-xt/issues/38#issuecomment-1998967698 and replacing:

I'm not sure if there's a nice way of rendering these replacements in a monochromatic fashion on Windows/Linux, however.

TuxedoTako commented 6 months ago

Could consider setting the font family as per https://github.com/TuxedoTako/4chan-xt/issues/38#issuecomment-1998967698 and replacing:

Just to be clear, I'm on windows, and the header icons look like this on windows:

msedge_eWny6KwA5G

The monochrome icons are from Segoe UI Symbol, which is why that has to be before Segoe UI Emoji. I'm hoping to find an Segoe UI Symbol equivalent on mac, but because I don't own one, I can't test mac font stacks myself myself.

Could consider setting the font family as per https://github.com/TuxedoTako/4chan-xt/issues/38#issuecomment-1998967698 and replacing:

On windows, those look like this:

Without Segoe UI Symbol:

image

With Segoe UI Symbol:

msedge_bQUQ2mOEkr

So those are usable, but that doesn't change the fact that a lot of icons are colored emoji on mac. It might also be broken on Linux.

If we can't find a good font for mac, I'm considering using the icons from https://github.com/ccd0/4chan-x/pull/2395. I would prefer if apple has a good icon font I can put in the stack, but picking and choosing icons is better than including all of of font awesome at least.

TuxedoTako commented 6 months ago

Since no apple user provided a good icon font, I'm switching back to font awesome. But this time only importing the icons that are actually used.

This will be in the next release, soonish. Code is already in the repo.

TuxedoTako commented 5 months ago

Moved back to Font Awesome in 2.7.0.

saxamaphone69 commented 4 months ago
Screenshot 2024-05-22 at 6 41 27 pm

FWIW, the menu icon at the end of posts and the thread watcher doesn't render on macOS/iOS either.