2.11 noticings

[saxamaphone69]

Things I've noticed on initial mucking around:

• #media-preview is added to doc as opposed to body
• videos respect max-width/height, but images don't - perhaps it follows what the user has set for Fit width/height, or on initial load the image is downscaled and then on click it zooms? Then clicking on the overlay or Esc closes it?
• videos don't autoplay as a blob when previewed, I'd figure if you click the preview button, you'd want the video to play
• videos don't receive a background-image in the dump list, is it possible to grab the first frame of the blob and use that?
• PDFs don't either, but I understand that is a bit harder. SWFs forget about it. In the absence of a file preview, perhaps "PDF"/"SWF" in the middle of the preview?
• Instead of allowing unsupported filetypes to be "uploaded" (e.g. .docx), would the use of accept help at all? Though, in saying that, since other sites (e.g. sushigirl) allow different types of files compared to 4chan, I can see why it's open for all files.
  • On that again, does/should XT care about supporting non-4chan websites? Do people continue to use X if they want cross-site support?
• There's a console.error when you upload an unsupported file type, but also an inbuilt notification. Not sure if it (the console error) is necessary then

Also completely unrelated to 2.11, but when going to /f/ on XT, you get a bunch of errors about things crashing (Filter, and the QR doesn't even open).

[TuxedoTako]

media-preview is added to doc as opposed to body

What do you mean? It's added to the overlay, and it's a class, not an ID.

On that again, does/should XT care about supporting non-4chan websites?

4chan X doesn't differentiate when checking either, I guess XT is just more agressieve about it now. I'll change it to only check on 4chan.

I guess I don't understand this extension completely yet.

There's a console.error when you upload an unsupported file type, but also an inbuilt notification. Not sure if it (the console error) is necessary then

The message on the page only shows the text, the console logs the full error object.

[saxamaphone69]

what do you mean

As in the element is added to html (doc as a var), not body. It's "outside" the scope of the document.

XT is just more aggressive

I meant more in the sense do you see XT as its own thing, as more than a fork/a successor of X where you can start applying your own biases and functions/features you deem worthy; or just an updated X and still wanting to maintain some sense of parity. Removing legacy stuff like support for obscure old browsers, having code that checks for site software, adding more features or completing long standing feature requests from X, etc.

If you still plan on supporting other variations of image boards, by all means, leave the code as is. Though to be honest I think QR doesn't even run on these other places whose supported file types include: jpg, jpeg, gif, png, webm, mp4, mp3, ogg, flac, pdf, txt, svg, zip, rar, cbz, cbr, 7z, gz, tar, avi, opus, m4a, swf, pdf so if it's a 4chan and XT mutually exclusive thing, maybe then it's okay.

[TuxedoTako]

videos don't receive a background-image in the dump list, is it possible to grab the first frame of the blob and use that?

Looks like this doesn't work in X either. It tries to grab a frame before the video is ready. Maybe the video didn't load asynchronous in past browser version?

• in saying that, since other sites (e.g. sushigirl) allow different types of files
  • On that again, does/should XT care about supporting non-4chan websites? Do people continue to use X if they want cross-site support?

Looking at shushigirl, it seems that they have their own quick reply, and no option to disable their native extension. Some XT features like filtering still work, like filtering, but if websites diverge too much from how 4chan does it, things might break. I don't think old 4chan X works in that case either.

I'll fix things if I broke them on the userscript side, but I'm not going to try to make this work on 10 different barely used imageboard forks.

Also completely unrelated to 2.11, but when going to /f/ on XT, you get a bunch of errors about things crashing (Filter, and the QR doesn't even open).

I don't think recaptcha ever worked on XT, I just never used /f/. I'm surprised it took this long for someone to tell me.

---

2.11.1 Fixes the errors on /f/, the thumbnails for videos, makes video preview autoplay, moves the preview to the body, and put the image extension in the thumbnail square for non video or image files.