Tw1ddle / samcodes-chartboost

:moneybag: Unofficial Chartboost ads support for Haxe/OpenFL Android and iOS targets
https://samcodes.co.uk/code/
MIT License
19 stars 4 forks source link

Build failed on version 1.0.7 #3

Closed stein-D closed 6 years ago

stein-D commented 7 years ago

It's seems the new version 1.0.7 cause build failed when combine with another library that already using google play service. Like "haxe-ga" / "extension-admob". I readed change log on 1.0.7, there is update "Add Google Play Services Android dependency". I think this cause the problem.

Thanks

Tw1ddle commented 7 years ago

Hi thanks for reporting, could you paste up the build error message? I tried compiling for Android with the haxe-ga and extension-admob included in Project.xml in my demo setup and do not get build errors.

Demo app is here if you want to try that: https://github.com/Tw1ddle/samcodes-ads-demo

stein-D commented 7 years ago

Here's the error preview, when I use 1.0.7 version. error

When I downgraded to 1.0.6 version. Everything works fine and no error.

Tw1ddle commented 7 years ago

I see, I was using an old OpenFL ~3.6.1 version that are compatible with HaxeFlixel in my demo app. The difference is probably that OpenFL 4.x uses Gradle, not ant.

The problem looks a lot like this - maybe you could work around this by editing a duplicate dependency: http://stackoverflow.com/questions/23494872/gradle-error-more-than-one-library-with-package-name-com-google-android-gms

If that doesn't help, then I will look into this over the weekend, failing that I'll certainly find a fix for this when HaxeFlixel is updated to support the latest OpenFL versions...

Tw1ddle commented 7 years ago

@stein-D I had another look at this and couldn't see the solution. I'm intending to wait until OpenFL 4.x support is added to Flixel (https://github.com/HaxeFlixel/flixel/pull/1940), since I'll be able to update my demo app and investigate better to fix this, sorry for inconvenience.

stein-D commented 7 years ago

@Tw1ddle Sure, Looking forward for it :). Thank you.

Tw1ddle commented 6 years ago

This should be fixed in the repo now that I've updated it and accompanying demo app for OpenFL 8 support. I'll push a new release to haxelib soon, after some more testing.

Thanks for reporting, let me know if you have any more issues.