allowing logging version above 1.6 and beyond 1.x

TwP / logging-rails

Railtie for integrating the Logging framework with Rails

81 stars 27 forks source link

allowing logging version above 1.6 and beyond 1.x #19

Closed gingerlime closed 9 years ago

gingerlime commented 9 years ago

see TwP/logging#108

TwP commented 9 years ago

Already fixed by a different PR

gingerlime commented 9 years ago

I might be wrong, but I think the other PR will only allow upgrading to 1.x, but not to 2.x though...

I would like to use 2.0 from master with logging-rails, but the version restriction prevents me from doing so, hence why I submitted the PR.

TwP commented 9 years ago

Correct. There will be corresponding version bump to logging-rails when logging 2.0 is released. Logging 2.0 is definitely not backwards compatible. Hence the major version bump.

gingerlime commented 9 years ago

I see. It seems to be working fine for us though (logging 2.0 and logging-rails - with the removed dependency), but maybe we're not using all features of logging to manage to break anything...(?)