search

TwP / logging

A flexible logging library for use in Ruby programs based on the design of Java's log4j library.
https://rubygems.org/gems/logging
MIT License
530 stars 101 forks source link

color_scheme arg is not being used #169

Open lardcanoe opened 7 years ago

lardcanoe commented 7 years ago

https://github.com/TwP/logging/blob/master/lib/logging.rb#L94

:color_scheme should be part of that array.

Without it I don't get colorized log output.

I'll open a PR if you agree that this is an oversight. Thanks!

TwP commented 7 years ago

Ah, I see what you're saying here. As the code stands right now, you cannot add colorization to a simple Logger instance created via the Logging.logger() method. You are proposing that :color_scheme be added as an option to the method.

:+1:

If you would love to take a stab at implementing the functionality, then please go ahead. Pull requests are always welcome :bowing_man: