search

TweakScale / Companion_Frameworks

Adds (up to date) TweakScale /L patches for Add'Ons that adds features to KSP itself, as Waterfall
GNU General Public License v2.0
1 stars 0 forks source link

This stopped working on KSP 1.12.x #1

Closed Lisias closed 2 years ago

Lisias commented 2 years ago

At least for KSP 1.12.2 (didn't tested .0 and .1), the plumes are not being scaled anymore as it was being done on 1.11.2.

This probably is happening because the current code is probably relying on a race condition (I can't revert to launch without losing the scaling!).

Fellow Kerbonaut hohmannson did a full report on TweakScale's thread:

KSP 1.12.2, Waterfall 0.6.7, Waterfall-Restock, Stock Waterfall Effects, Tweakscale 2.4.5.1, Tweakscale Companion Visuals 0.1.0.0, plumes are not scaled and Kerbal Object Inspector doesn't see the companion's module on engines. Seems to not be a problem of plume patches, because even custom engine with custom plume doesn't get scaling.

Log: wfcomp_failed_log.zip

Lisias commented 2 years ago

The racing condition hypothesis has teeth.

  1. I reverted Waterfall to 0.6.6 , the version I used it for the last time, the problem persists.
  2. I have a report that the previous release of Waterfall "kinda works":

Also - if you use a previous version of companion, it mostly works, module appears, plumes of engines scales(sometimes no RCS) - but produces logspam in VAB exactly like in my previous report. Hope it helps - and i wish you luck!

Lisias commented 2 years ago

I tried older verions of the Visuals, as well older versions of Waterfall. No change on the behaviour.

Interesting enough, no logspam neither. I suspect that something on Hohmannson's GameData is changing the order of some events, and this is the reason the race condition we have here ended up kinda of working for him.

In a way or another, there's no other action to be taken but to start from scratch again. This time, trying to avoid relying on race conditions to work.

Lisias commented 2 years ago

HOLLY CRAP!!!

What's happening is that KSP 1.12.2 SCREWED UP with the Dependency Checks!!! Jesus Christ, man….

[WRN 08:03:14.485] AssemblyLoader: Assembly 'TweakScalerModuleWaterfallFX' has not met dependency 'Scale_Redist' V1.0.0
[WRN 08:03:14.485] AssemblyLoader: Assembly 'TweakScalerModuleWaterfallFX' is missing 1 dependencies
Lisias commented 2 years ago

Fixed on commit https://github.com/net-lisias-ksp/TweakScaleCompanion_Visuals/commit/67febf335641b6370aa060b69a6be1eea0c6944b

(HOLLY CRAP!!)

Lisias commented 2 years ago

Clsoing again. KSP 1.12.2 is innocent on a recent report I got.