TweakScale / Companion_FuelSwitches

Adds (up to date) TweakScale /L support for Fuel Switches, allowing parts using them to be scaled if patches are applied.
GNU General Public License v2.0
0 stars 0 forks source link

Rescaling Tanks affect maximum fuel content (when Alt+clicking or detaching/reattaching tanks) #2

Open Xithyl515 opened 2 years ago

Xithyl515 commented 2 years ago

I have tweakscale installed as well as 77 other mods, as discussed in the KSP forums. When I rescale a tank, it initially recognizes the proper fuel values in the tank. Below is my screenshot of tanks that I tweaked after spawning them in. I chose to use stock parts to hopefully remove some mod bias.

image

Below is a screenshot of the uncopied tanks working properly on the launchpad

image

Below is a screenshot of the tanks AFTER I revert to the vehicle assembly building, I didn't have to even copy the tanks, simply returning to the VAB resets the tank capacities of my tweaked tanks. (Copying the tweaked tanks also resets their capacity).

image

The vessel in the screenshots has been named "Stacked Cake" and I've added it, KSP.log, output_log, Player.log, modulemanager logs, and module manager files from GAMEDATA. Please let me know if I need to provide anything additionally to help resolve the issue.

DROPBOX: https://www.dropbox.com/s/c2eo2pfqo9y9btq/KSP%20ISSUE%20ZIPPED.zip?dl=0

Thank you.

Lisias commented 2 years ago

Ah! So reverting to the SPH/VAB was the trigger! I will check this after midnight - I'm having a hell of a Friday 13th on day job, and I don't want to further push my luck with Murphy today!!! :D

Xithyl515 commented 2 years ago

It happens for Alt+click copying as well. I was curious so I tested it on other objects. It seems Reaction wheels are also cursed. I am able to see the gyro torque through the mod: TweakableEverythingContinued. image Oddly enough, the communication antenna rating is unaffected by this bug, even when I revert back to the VAB image

No worries in rushing to fix this, I've been working around it no problem.

Lisias commented 2 years ago

Yep, the problem appears to be specific to Resources, not PartModule capabilities.

Trying to reproduce it on my rig,

Lisias commented 2 years ago

@Xithyl515 ,

Nope. It worked fine on my rig. It's definitively some interaction with something installed on your rig. [EDIT: Nope, see below. and also #1 ]

Well, the easy picks are over. Now I need to do some real digging on the matter by analysing the data you provided and installing the add'ons gradually until I reproduce the problem...

Lisias commented 2 years ago

Oukey, by opening the Stacked Cake craft, I found that one of the tanks have the Resources different from what I would expect:

       RESOURCE
       {
               name = LiquidFuel
               amount = 37.968753218650818
               maxAmount = 90.000007629394531     <—— Whoopsy!!
               flowState = True
               isTweakable = True
               hideFlow = False
               isVisible = True
               flowMode = Both
       }
       RESOURCE
       {
               name = Oxidizer
               amount = 46.406256437301636
               maxAmount = 110.00001525878906     <—— Whoopsy!!
               flowState = True
               isTweakable = True
               hideFlow = False
               isVisible = True
               flowMode = Both
       }

So I deleted the affected part, duplicated the bigger one, put it on top, shrink it, launched the thing and reverted to VAB.

The problem was not reproduced, it's indeed something on your rig [EDIT: Nope, see below. and also #1 ].

Obviously, I did the tests on an (almost) naked KSP installment. I will now install back Configurable Containers to see if it's the cause of the problem, as I found its PartModules on the affected part:

Screen Shot 2022-05-14 at 00 31 19

Lisias commented 2 years ago

Reproduced it exactly as described by @Xithyl515 .

screenshot55

It's appears to be a tug of war between TweakScale and Configurable Containers, or perhaps a missing Exponent for something?

In a way or another, I need to rule out KSP interference first - I think that something like this would had been reported before if it was something on TS or CC…

If this is something related to KSP (i.e., on previous versions of KSP it works fine) this issue must be transferred to KSP-Recall.

Otherwise, it's a lack of proper support issue. Then it will be moved to the TweakScale Companion Program.

Lisias commented 2 years ago

In time, it appears interestingly similar to an issue I have with Waterfall.

https://github.com/net-lisias-ksp/TweakScaleCompanion_Frameworks/issues/3

Lisias commented 2 years ago

The misbehaviour was reproduced on KSP 1.8.1, way before the crapness that hit KSP 1.9.1 editor.

So it's a TweakScale Companion Program task. Moving to it.

Lisias commented 2 years ago

DAMN

This was already reported last year, and I completely forgot about!!

https://github.com/net-lisias-ksp/TweakScaleCompantion_FuelSwitches/issues/1

Lisias commented 2 years ago

Changing from Support to Enhancement, as this is a new feature to be implemented on TSC-FuelSwitches.

Lisias commented 2 years ago

Support link https://ksp.lisias.net/add-ons/TweakScale/Support/SanityChecks/ConfigurableContainers