search

TweakScale / Companion_PKMC

TweakScale Companion Patches for Near Future Add'Ons
GNU General Public License v2.0
4 stars 1 forks source link

Resizing of stock parts cause attachment issues #6

Open Jammer-TD opened 3 years ago

Jammer-TD commented 3 years ago

I was able to create this issue and Identify that the problem goes way, when RESTOCK PARTS Mod By @netea is removed. [1.11.1] Restock - Revamping KSP's art (KSP 1.11, Jan 31).. I didn't think this was the exact same as others reported with attachment, merge to any outstanding Item if needed. Attached logs" ts2446-1.11.2-01.zip Here is normal: NP-no_restock-ts245 Here not so much: Sym-Prob-restock-ts245 The item is a single panel with a sym connected duplicate to each side then resized! just thought I would let you know I am not sure whom could resolve this as, without RECALL PARTS the problem goes away so maybe it on them. thanks Jammer

Lisias commented 3 years ago

We have a bug on Symmetry on KSP itself, and TweakScale not being able to handle perfectly all the symetries use case does not helps neither.

I will investigate. ReStock may be using some hidden feature on KSP that I'm missing.

Jammer-TD commented 3 years ago

So Just for assistance of Identifying this better for you. I tried various combination's, reverting both restock and TS. this error only develops after ts2.4.4.2(which works fine)! v2.4.4.3 complains about ksp version, and the issue appears, v2.4.4.4 has no "houston's" but the issue is present, and same for v 2.4.4.5. I just thought this may help to know. Jammer-TD ts2443-1.11.2-01.zip

Lisias commented 2 years ago

I'm moving this to be tackled down sooner, as I think this just bitten me while doing some tests for another Fellow Kerbonaut.

Lisias commented 2 years ago

Note to myself: I had my ass bashed mercilessly on DistantObject on a similar problem with ReStock.

Long history made short: ReStock 1.4.2 (at least) is replacing some Stock Modules with their own versions, and I need to inspect and learn about these new PartModules in order to have this sorted out for both TweakScale and DistantObject.

So this is not a bug anymore, but an enhancement - and I will post pone it to a Milestone dedicated only to enhancements.

Lisias commented 2 years ago

Craft file: craft.zip

Evidence of the thing working: screenshot46 screenshot47

TODO: use this craft to check the behaviour on KSP 1.12.2 with and without ReStock

Lisias commented 2 years ago

This is confirmed to be something related to ReStock.

Moving the issue to the TSCo-PKMC where it will be tackled own.